Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter name decoding when using POST + urlencoded #5876

Merged
merged 1 commit into from Dec 18, 2017

Conversation

peppsac
Copy link
Contributor

@peppsac peppsac commented Dec 15, 2017

Description

This is a followup of dfe48d1 which solved the issue for parameter values.

Fix https://issues.qgis.org/issues/17694

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@pblottiere
Copy link
Member

Nice, thank you @peppsac!

Can you just update your commit message with something like Fixes #17694 ...? This way the corresponding issue will be automatically closed once this PR merged.

@pblottiere
Copy link
Member

Can you just update your commit message with something like Fixes #17694 ...? This way the corresponding issue will be automatically closed once this PR merged.

My apologies, it's already done 👍

@peppsac
Copy link
Contributor Author

peppsac commented Dec 15, 2017

There's a similar problem to fix: + in parameters aren't converted to space (eg: LAYERS=my+layer should become LAYERS=my layer).
Do you me to push a 2nd commit to fix this in this PR? Or should I open a different PR?

@pblottiere
Copy link
Member

Do you me to push a 2nd commit to fix this in this PR? Or should I open a different PR?

If it's linked to POST method and url encoding too, then I'd say that doing this fix in this PR is OK.

Otherwise, another PR would be welcomed :)

@peppsac
Copy link
Contributor Author

peppsac commented Dec 15, 2017

Ok since it's exactly at the same place I amended the commit to fix the + to space conversion as well.

This is a followup of dfe48d1 which solved
the issue for parameter values.

Fixes qgis#17694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants