remove rtype from docstring #5883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nope, looks good to me. This is your baby after all :) |
3nids
force-pushed
the
removertype
branch
2 times, most recently
from
9e77445
to
a3f5214
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return type is often wrong as soon as you have
/Out/arguments.For instance
I have patched SIP to get the Python signature in the docstring (as in the image above) which gives great output.
It might be possible to try to do it in sipify, but it would be tricky....
Anyone has an objection?
@nyalldawson you introduced this IIRC.