Delimited text to core

[ccrook]

This should implement getting the delimited text moved from plugin to core.

Only one thing I'm not sure about in terms of implementation approach, which is adding another signal to Qgis app, addSelectedVectorLayer, which is directly equivalent to addVectorLayer. Not sure whether there is any reason not to make addVectorLayer(QString,QString,QString) a slot and bypass this additional function, but chose not to change this...

I seem to have build this on top of the previous pull request (delimited_text_gui_cleanup). Hopefully not a problem.
I can pick out the last commit to just get the move to core if required.

[NathanW2]

That's a lot of changes, but it really should be core and not a plugin. @timlinux your call.

[ccrook]

Hi Nathan

Yup. Move to core was Tim's suggestion, so I'm guessing it will be good to go.

Cheers
Chris

---

From: Nathan Woodrow [notifications@github.com]
Sent: 14 May 2013 18:29
To: qgis/Quantum-GIS
Cc: Chris Crook
Subject: Re: [Quantum-GIS] Delimited text to core (#591)

That's a lot of changes, but it really should be core and not a plugin. @timlinuxhttps://github.com/timlinux your call.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/591#issuecomment-17858941.

This message contains information, which is confidential and may be subject to legal privilege. If you are not the intended recipient, you must not peruse, use, disseminate, distribute or copy this message. If you have received this message in error, please notify us immediately (Phone 0800 665 463 or info@linz.govt.nz) and destroy the original message. LINZ accepts no responsibility for changes to this email, or for any attachments, after its transmission from LINZ. Thank You.

[timlinux]

Thanks so much for this Chris! Could you have a look at the merge conflicts? I will merge it when they are resolved.

[ccrook]

This should be good now ..

[ccrook]

Ooops!

[nirvn]

@ccrook , am I wrong in thinking that this pull request includes what you were pushing in this other pull request (#589)?

Glad this is moving into core, one less plugin to activate when doing a fresh install :)

[timlinux]

Thanks for this Chris!

[ccrook]

Likewise thanks

---

From: Tim Sutton [notifications@github.com]
Sent: 17 May 2013 19:18
To: qgis/Quantum-GIS
Cc: Chris Crook
Subject: Re: [Quantum-GIS] Delimited text to core (#591)

Thanks for this Chris!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/591#issuecomment-18047133.

This message contains information, which is confidential and may be subject to legal privilege. If you are not the intended recipient, you must not peruse, use, disseminate, distribute or copy this message. If you have received this message in error, please notify us immediately (Phone 0800 665 463 or info@linz.govt.nz) and destroy the original message. LINZ accepts no responsibility for changes to this email, or for any attachments, after its transmission from LINZ. Thank You.

[ccrook]

Yes, you are correct .. forgot to switch back to master before making the changes to move to core, and didn't notice till I'd put in the pull request. All history now in any case!

Cheers
Chris

---

From: nirvn [notifications@github.com]
Sent: 17 May 2013 18:37
To: qgis/Quantum-GIS
Cc: Chris Crook
Subject: Re: [Quantum-GIS] Delimited text to core (#591)

@ccrookhttps://github.com/ccrook , am I wrong in thinking that this pull request includes what you were pushing in this other pull request (#589#589)?

Glad this is moving into core, one less plugin to activate when doing a fresh install :)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/591#issuecomment-18046049.

This message contains information, which is confidential and may be subject to legal privilege. If you are not the intended recipient, you must not peruse, use, disseminate, distribute or copy this message. If you have received this message in error, please notify us immediately (Phone 0800 665 463 or info@linz.govt.nz) and destroy the original message. LINZ accepts no responsibility for changes to this email, or for any attachments, after its transmission from LINZ. Thank You.