Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[layouts] improve lock item(s) / unlock all toolbar icons #5929

Merged
merged 1 commit into from Dec 22, 2017

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Dec 21, 2017

Description

@nyalldawson , fixing a long-standing irritant of mine, whereas the lock item(s) and unlock all toolbar icons where 16 x 16 (the only ones), which clashed with the other 24 x 24 icons.

Before vs. proposed:
screenshot from 2017-12-21 15-35-31

The unlock all icons also does a better job at indicating that all items will be unlocked.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@nyalldawson
Copy link
Collaborator

+1

@nirvn nirvn merged commit 224dcd0 into qgis:master Dec 22, 2017
@nirvn nirvn deleted the layouts_toolbar branch February 26, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants