[user input widget] use a floating widget rather than a dock #6056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merging as is, the spinbox size issue was already there in dock widget. |
Fixed for me by https://github.com/qgis/QGIS/pull/6073/files - the floating widgets weren't correctly responding to size changes. |
|
and +1 to this change in general! |
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15177
TODO
@nirvn could you give a hand at giving more room to the comboboxes in the rotation user input widget? I tried to use minimumExpanding both for comboboxes and user input main layout without success...
@nyalldawson it seems that the widget is not always well placed on first show (before any repaint). Am I missing something?