Use FIND_LIBRARY to find GDAL, GEOS and Postgres libraries #6171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OpenBSD, there's no libgdal.so symlink, only a versioned library (ie
libgdal.so.X.Y where X.Y changes over time so is never constant)
Using cmake's FIND_LIBRARY allows to let cmake find the library.
Without this, the build would fail on OpenBSD:
ninja: error: '/usr/local/lib/libgdal.so', needed by 'output/lib/libqgis_core.so.18.0', missing and no known rule to make it
Description
I'm not sure the linux distros end up in this cmake codepath, but it should cause no regressions there, and allows me to upstream 3 patches i've been carrying since years (cf http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/geo/qgis/patches/patch-cmake_FindGDAL_cmake?rev=1.10&content-type=text/x-cvsweb-markup , http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/geo/qgis/patches/patch-cmake_FindGEOS_cmake?rev=1.11&content-type=text/x-cvsweb-markup and http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/geo/qgis/patches/patch-cmake_FindPostgres_cmake?rev=1.9&content-type=text/x-cvsweb-markup - those patches were OpenBSD-specific with LOCALBASE, but the PR reuses the paths provided by the cmake module)
Checklist
fixes #11111
in the commit message next to the description[FEATURE]
in the commit message[needs-docs]
in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.sh
script before each commit