Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "Edit rule" dialog instead of widget when in Layer properties dialog #6187

Merged
merged 4 commits into from
Feb 19, 2018

Conversation

DelazJ
Copy link
Contributor

@DelazJ DelazJ commented Jan 27, 2018

Also add help button and better management of scrollbar (avoid it in the layer styling panel) - refs #17903
before vs after (layer properties) - any way to get rid of the frame?
image
before vs after (layer styling - the frame is gone)
image

and not in widget mode
Sur la branche rulebaseDialog
	modifié :         src/app/nodetool/qgsnodetool.h
aucune modification n'a été ajoutée à la validation (utilisez "git add" ou
@DelazJ
Copy link
Contributor Author

DelazJ commented Jan 28, 2018

Btw, there's an issue with spinbox value being partial hidden. I thought this had been fixed…

@elpaso
Copy link
Contributor

elpaso commented Feb 19, 2018

LGTM, can I merge or do you want to fix the spinner first?

@elpaso elpaso self-assigned this Feb 19, 2018
@DelazJ
Copy link
Contributor Author

DelazJ commented Feb 19, 2018

Thanks for looking into this @elpaso
I can't see the spinbox issue in my recent nightlies on Windows (note that the screenshot is from Ubuntu, in case...) so please merge

@elpaso elpaso merged commit 6da78b9 into qgis:master Feb 19, 2018
@DelazJ DelazJ deleted the rulebaseDialog branch February 27, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants