[console] Allow breaking execution of scripts via Ctrl-C #6213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows (in some circumstances) scripts running in the console
to be halted via the Ctrl (or Meta) + C shortcut.
(It's only possible to catch and abort when the script is printing
outputs to the console - because this triggers
QCoreApplication.processEvents() calls. Without these calls the
whole QGIS application is unresponsive during script execution
and there's no ability to even catch a shortcut in order to
halt the execution.
Still, even with this limitation it's handy to be able to
break out of lengthy:
for f in iface.activeLayer().getFeatures():
print(f.attributes())
loops!)
|
On a hack level of 0 (not a hack) to 10 (gross hack) this is a 7. |
|
I'm fine with this hack, it brings a nice feature and it's not a ton of code. Merge? |
|
Only we know it's a hack which in case it's a feature. Merge it.
…On Fri, Feb 2, 2018 at 11:50 PM, Denis Rouzaud ***@***.***> wrote:
I'm fine with this hack, it brings a nice feature and it's not a ton of
code. Merge?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6213 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAXS3OsgTAiExOcg7OP1ziAR4qs2N4Zhks5tQxKUgaJpZM4RxjpU>
.
|
|
too much noise... ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows (in some circumstances) scripts running in the console to be halted via the Ctrl (or Meta) + C shortcut.
(It's only possible to catch and abort when the script is printing outputs to the console - because this triggers QCoreApplication.processEvents() calls. Without these calls the whole QGIS application is unresponsive during script execution and there's no ability to even catch a shortcut in order to halt the execution.
Still, even with this limitation it's handy to be able to break out of lengthy:
for f in iface.activeLayer().getFeatures():
print(f.attributes())
loops!)