Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[needs-docs][Gui] Reorganize Interface customization dialog #6233

Closed
wants to merge 2 commits into from

Conversation

DelazJ
Copy link
Contributor

@DelazJ DelazJ commented Jan 31, 2018

Because you first need to check the "Enable customization" box to interact with the whole dialog, it should the first item proposed (otherwise, it's not really obvious/smooth).
I also think that with this configuration a search box could also find its place (...one day...)
image

"Enable customization" checkbox should be at top given that it's what rules the whole behavior of the dialog
@nirvn
Copy link
Contributor

nirvn commented Jan 31, 2018

I'm not convinced by this change. I'd like to hear from others too.

@nyalldawson
Copy link
Collaborator

I'm also not convinced - to me the move away from the standard toolbar is a step back. I also wonder if some of those actions should apply when interface customization is disabled. E.g. should we enable "load", and make that auto-enable the customization?

@DelazJ
Copy link
Contributor Author

DelazJ commented Feb 1, 2018

I'm also not convinced - to me the move away from the standard toolbar is a step back.

Sorry but I fail to understand your "not convinced". Actually i really fail to understand the current implementation: each time I came to this dialog, it was like "hum... how is it that all is grayed? What do I need to do? Ah yes... I need to toggle the box at the middle of the dialog to enable all the buttons at the top. Ah yes, that is it!" In order words, i don't find the current situation obvious nor fluent.
Also, is there a requirement to use a qtoolbar here? Afaict, none of our dialogs nor panels use this kind of widget. They tend to use buttons.
The proposed implementation also mimics what we already provide in most of the existing panels/dialogs: list of tools near the frame they interact with. See layers panel, Processing toolbox (which also offers a search box that I think would be nice to have in this dialog) ...

E.g. should we enable "load", and make that auto-enable the customization?

I wonder if "Load" and "Save" buttons should not be moved to the bottom of the dialog (like in Keyboard shortcuts dialog) and then move to top the "Reset" option (like an icon).

@jmarsac
Copy link

jmarsac commented Feb 1, 2018

IMHO I prefer the current location under the toolbar for checkbox but I agree with Harrissou for moving Reset button as an icon in the toolbar (leaving "Load" and "Save" in toolbar) and also for adding search box.
+1 to enable "Load" and make that auto-enable the customization

@alexbruy
Copy link
Contributor

alexbruy commented Feb 1, 2018

-1 for this change. I expect standard layout with toolbar on the top. Also IMHO "Reset" button should be a toolbar action.

@DelazJ
Copy link
Contributor Author

DelazJ commented Feb 18, 2018

Thanks for your inputs.
Can someone either summarize the outcome of the discussion (i'll then try to convince you but not before the release, as my build computer is currently broken) or do the requested changes, please?

@nyalldawson
Copy link
Collaborator

Closing due to many -1 comments.

@nyalldawson nyalldawson closed this May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants