Misc optimizations for everything #6300
Merged
+181
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuarte47
reviewed
Feb 9, 2018
| else | ||
| { | ||
| lineStringX.append( x ); | ||
| lineStringY.append( x ); |
There was a problem hiding this comment.
Yes, good catch!
This is used a lot, yet the current constructor calls the normalize() method which does a bunch of operations for no result. So instead provide a simple optimised null QgsRectangle constructor and save a lot of cycles. Refs qgis#17809
WKB type, and use optimized method instead Refs qgis#17809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into https://issues.qgis.org/issues/17809, this is all I've been able to identify with the profilers at hand. None had particularly significant impacts on the rendering speed though. (Overall around ~ 5-10% improvement).