Don't silently discard requests to set QgsFieldExpressionWidget to an empty expression #6312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to an empty expression This causes issues in lots of places - e.g. a field constraint is always set to the first field in a layer, and cannot be removed. I've looked at all calls to setField and without exception they should accept that setting the field to an empty string results in an empty expression. Fixes qgis#14325
|
@3nids here you go - something else to puzzle your head over. |
3nids
approved these changes
Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes issues in lots of places - e.g. a field constraint is always set to the first field in a layer, and cannot be removed.
I've looked at all calls to setField and without exception they should accept that setting the field to an empty string results in an empty expression.
Fixes #14325, and supersedes #2810