Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[welcomepage] fixes #18118 remove last item causes a crash #6369

Merged
merged 1 commit into from Feb 19, 2018

Conversation

slarosa
Copy link
Member

@slarosa slarosa commented Feb 17, 2018

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be beginRemoveRows/endRemoveRows?

@slarosa
Copy link
Member Author

slarosa commented Feb 17, 2018

@nyalldawson yes, my first fix was that, but it crashes yet, so I tried to reset model. Testing again the beginRemoveRowshas worked, maybe a local and temporary problem :-). I am addressing your comment.

Thanks for reviewing.

@nyalldawson
Copy link
Collaborator

Let's try this fix - I think if there's still a crash there's another issue present too.

@nyalldawson nyalldawson merged commit da7ccf7 into qgis:master Feb 19, 2018
@slarosa slarosa deleted the fix_18118_crash branch October 12, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants