allows to add default XYZ Tiles Servers

[slarosa]

Description

This PR adds an action which allows adding some default XYZ servers [0] from Browser Panel. I wondering if this could be useful for users which feel lost without QMS plugin :-)

[0] - https://www.spatialbias.com/2018/02/qgis-3.0-xyz-tile-layers/

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

• Commit messages are descriptive and explain the rationale for changes
• Commits which fix bugs include fixes #11111 in the commit message next to the description
• Commits which add new features are tagged with [FEATURE] in the commit message
• Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
• I have read the QGIS Coding Standards and this PR complies with them
• This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
• New unit tests have been added for core changes
• I have run the scripts/prepare-commit.sh script before each commit

[nyalldawson]

Ooooh careful here - we can't ship with the esri or Google tiles, that's asking for trouble!

[nyalldawson]

What I'm wondering here is whether it's better to just add the (suitably licensed) ones by default, like we do now for OSM. I think that might be a better approach, because it avoids the action which is hard to discover, and users can easily remove default ones they don't want.

[luipir]

as far as I rememebr there where a discussion and or PR by @jgrocha regarding add or not by default OSM tiles.

[luipir]

what about to have all these defaults get from the global settings of QgsSettings? in this way QGIS package can be customised basing on what is the target.

[NathanW2]

Yes, please. That is the correct way to do this. Put it in the global settings file.

…

On Wed, Mar 7, 2018 at 8:37 AM, Luigi Pirelli ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/providers/wms/qgswmsdataitems.cpp <#6546 (comment)>: > @@ -488,6 +496,38 @@ void QgsXyzTileRootItem::newConnection() QgsXyzConnectionUtils::addConnection( dlg.connection() ); refreshConnections(); } + +void QgsXyzTileRootItem::addDefaultXYZServers() +{ + QMap<QString, QString> defaultXYZServers; + defaultXYZServers[QStringLiteral( "OpenStreetMap Mapnick" )] = QStringLiteral( "http://tile.openstreetmap.org/{z}/{x}/{y}.png" ); what about to have all these defaults get from the global settings of QgsSettings? in this way QGIS package can be customised basing on what is the target. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6546 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAXS3JpxZCaKvtXIERTFu7WbkTaBrWLaks5tbw-tgaJpZM4SfXSq> .

[jgrocha]

OSM tiles is already available

In previous discussions, we decided (on dev list) just to provide OSM tiles by default. OSM database and tile usage license is clear.

We we also talked with OSMF about this option in QGIS and we use our User-Agent to let them know that is QGIS requesting the tiles.

That's why we already have OSM tiles available by default (PR #5000). If you start QGIS 3 for the first time (just create another profile to start with default settings) you will see the default OSM tiles.

The data about the OSM service is not hard coded. It is in resources/qgis_global_settings.ini. If, for some reason, we choose another tile provider, we just need to change the default settings distributed with QGIS.

No code required

This can be accomplished without any code. Just add those entries to resources/qgis_global_settings.ini.

Customization

Since no code is required to have additional XYZ provides, companies deploying QGIS can custumize additional XYZ provides.

Thanks @luipir and @nyalldawson for previous comments.

[nyalldawson]

Just to clarify my position -- I'm all for adding more tiles in the default install, so long as we're playing by the rules 👍

[andreasneumann]

Thanks for adding these.
However, I agree with Nyall and others. Do not add ESRI/Google/Bing tiles unless we have written approval by them that we are allowed to include them.

We don't want troubles or law suits.

[slarosa]

Sorry, I did not want break the rules, really that was not my intention, and I did not remember @jgrocha's PR, so it is not necessary to add further code here to do that.

My intention was add some default server as I am seeing much community requests about the difficulty to display base tile layers.

Thanks all and sorry for the noise.

[luipir]

hei @slarosa no problem... that's the sense of review :)
BTW it's clear that make sense to add the QAction "add defaults" and it'zs good improvements to avoid initial users to be lost without base maps.

[jgrocha]

You are right @slarosa. Users should know how to add these optional map sources to QGIS, using qgis_global_settings.ini or taking adantage of user profiles. This lacks documentation.

You could write a nice post about "QGIS 3: How to add more default XYZ servers?" in your blog.