Make a few strings translatable by not changing them before translation. #6556
Conversation
|
Hmm. It seems that another change was added to this (probably should not create PRs from master). The other change fixes a missing default color mode in gdaldem color-relief. |
| @@ -221,7 +221,7 @@ def accept(self): | |||
| self.cancelButton().setEnabled(self.algorithm().flags() & QgsProcessingAlgorithm.FlagCanCancel) | |||
| if executeIterating(self.algorithm(), parameters, self.iterateParam, context, feedback): | |||
| feedback.pushInfo( | |||
| self.tr('Execution completed in {0:0.2f} seconds'.format(time.time() - start_time))) | |||
| self.tr('Execution completed in {0:0.2f} seconds').format(time.time() - start_time)) | |||
There was a problem hiding this comment.
Syntax error: extra closing bracket
There was a problem hiding this comment.
No, one added one removed.
| feedback.pushInfo(self.tr('Results:')) | ||
| feedback.pushCommandInfo(pformat(results)) | ||
| else: | ||
| feedback.reportError( | ||
| self.tr('Execution failed after {0:0.2f} seconds'.format(time.time() - start_time))) | ||
| self.tr('Execution failed after {0:0.2f} seconds').format(time.time() - start_time))) |
There was a problem hiding this comment.
Yes, forgot to remove from the end.
|
Please have a look to the test results, click on 'Details' after "The Travis CI build failed" and examine the logs. |
|
@ajolma Thanks for your contribution. It's often better to create a new branch, and then make a PR based on that branch. One branch per patch/feature. |
|
@alexbruy: would you mind approving the change in the ColorRelief.py? The processor is missing the option to leave out both --exact_color_entry and -nearest_color_entry, i.e., have the default mode "the colors between the given elevation values are blended smoothly". As for the translations I think the fixes are more self-evident. |
|
Hi Ari, thanks for this fixes. If I were you I would pull back this PR, and create a branch for your translations fix, and another one for the color relief thingie. Then both are tested on Travis separately and can be reviewed separately. Are you editing on Github? Or building/testing/branching on your own machine? |
Description
This is a very small fix to make a few strings translatable by not changing them before translation.