Fix attribute form position/size is remembered only per layer/feature combo #6611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the attribute table dialog object name is set to match the layer/featureid combo, this commit was causing the attribute form dialog to remember its position and size for each feature/layer combo individually. That's NOT what we want! Fixes qgis#18426
|
sorry. |
|
@slarosa no need to apologise for work you've generously donated! |
NathanW2
reviewed
Mar 16, 2018
| { | ||
| // WARNING!!!! Don't use QgsGui::enableAutoGeometryRestore for this dialog -- the object name | ||
| // is dynamic and is set to match the layer/feature combination. | ||
| QgsSettings().setValue( QStringLiteral( "Windows/AttributeDialog/geometry" ), QDialog::saveGeometry() ); |
There was a problem hiding this comment.
@nyalldawson are you sure we can't use enableAutoGeometryRestore here. Pretty sure I added support for dynamic keys if not I can have a look at how.
There was a problem hiding this comment.
If anything just use the same settings wrapper that enableAutoGeometryRestore does so we can keep the logic in one place.
There was a problem hiding this comment.
Got an example? I tried this approach originally but couldn't work out out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert 5b9be7a
Since the attribute table dialog object name is set to match
the layer/featureid combo, this commit was causing the attribute
form dialog to remember its position and size for each
feature/layer combo individually.
That's NOT what we want!
Fixes #18426