Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] value relation widget with Allow multiple selection doesn't resolve #6615

Merged
merged 1 commit into from Mar 15, 2018
Merged

[bugfix] value relation widget with Allow multiple selection doesn't resolve #6615

merged 1 commit into from Mar 15, 2018

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Mar 15, 2018 •
edited by luipir

Now it will accept arrays as well as string representations of arrays

Added a test

Fixes #16967 value relation widget with Allow multiple selection doesn't resolve the values anymore

Description

Include a few sentences describing the overall goals for this PR (pull request). If applicable also add screenshots.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@elpaso
[bugfix] value relation widget with Allow multiple selection doesn't …
4f05ed1 
…resolve

Now it will accept arrays as well as string representations of arrays

Added a test

Fixes qgis#16967 value relation widget with Allow multiple selection doesn't resolve the values anymore
@luipir luipir changed the title [bugfix] value relation widget with Allow multiple selection doesn't … [bugfix] value relation widget with Allow multiple selection doesn't resolve Mar 15, 2018
@luipir luipir self-requested a review March 15, 2018 15:29
luipir
luipir approved these changes Mar 15, 2018
View reviewed changes
Copy link
Contributor

@luipir luipir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

texed and it fixes #16967

@luipir luipir merged commit 685adbf into qgis:master Mar 15, 2018
@qgib qgib mentioned this pull request May 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luipir luipir luipir approved these changes

Assignees
No one assigned
Labels
Needs Backporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elpaso @luipir