Fix identify tool with rule renderer and nested else

[m-kuhn]

See #6679 (comment)

Nested else rules would no longer work with the identify tool

[nyalldawson]

Could we get a test for this?

[m-kuhn]

As soon as it no longer segfaults

[nyalldawson]

Thanks! I think this logic may be duplicated in rule based labelling too, so that may also need the fix.

[m-kuhn]

Can you point me to code?

[nyalldawson]

Can you point me to code?

Ignore me - I'm wrong!

[pblottiere]

Hi @m-kuhn,

Sorry for the regression 😕.

I didn't test theses changes, but it LGTM, especially seeing unit tests.

Thank you!

[m-kuhn]

@pblottiere no worries, that can happen. Any of us would vastly overestimate the own capabilities by saying that he never caused a regression :)

[roya0045]

I think this fix should have also been applied to QgsRuleBasedRenderer::Rule::legendKeysForFeature as the issue fixed is still present in the layout legend.