Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolation fixes #6821

Merged
merged 2 commits into from Apr 19, 2018
Merged

Interpolation fixes #6821

merged 2 commits into from Apr 19, 2018

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Apr 19, 2018

Description

Unfortunately, I just discovered we shipped QGIS 3.0 with broken processing interpolation algorithms. This PR fixes that.

@nyalldawson , I'll backport once you OK these fixes.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@nirvn
Copy link
Contributor Author

nirvn commented Apr 19, 2018

I should probably add a note on the ::~:: change. We can't use a comma as separator in our interpolation data widget since memory / temporary scratch layers use comma to define fields, e.g.:

memory?geometry=Point&crs=EPSG:4326&field=StationId:text(0,0)&field=ProviderId:integer(0,0)&field=ProviderName:text(0,0)&field=StationName:text(0,0)&field=Latitude:double(0,0)&field=Longitude:double(0,0)&field=ElevationAboveSeaLevelMeters:double(0,0)&field=DisplayFlag:integer(0,0)&field=temp:double(10,2)

@nyalldawson
Copy link
Collaborator

Just goes to prove my view that the most fragile part of processing is now the gui components. I'd love ideas for what we can do to improve this.

But good fix, merge away (and quickly backport for 3.0.2 !)

@nirvn nirvn merged commit a463858 into qgis:master Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants