Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise project menu #6971

Merged
merged 5 commits into from
May 11, 2018
Merged

Reorganise project menu #6971

merged 5 commits into from
May 11, 2018

Conversation

nyalldawson
Copy link
Collaborator

The project menu has become a huge mess of random items in an illogical order:

before

This PR cleans it up by:

  • grouping similar actions together and using separators more effectively
  • moving the import/export actions to a submenu
  • adding consistency to action names

After:

after

I'd like to also move some of the Layouts actions to further reduce clutter. I think the "New Print Layout" and "New Report" actions should be moved into the "Layouts" submenu. Any objections here?

@nirvn
Copy link
Contributor

nirvn commented May 11, 2018

  • I'm not sure how I feel about save map as image/PDF... action being in the import/export sub-menu. I get why it makes sense for those to be there, and maybe it's just the habit of having used those so many times before it's hard to see those anywhere else. Maybe changing the wording to "Export Map as Image..." would make the actions sit better there?
  • On the "close project" -> "close" action renaming, I have no problem with that, but it does highlight a tiny bit of an issue with the locator bar's way of handling shortcuts. ATM, if you type ". close" in the locator bar, you'll see the "close project" action. If it's renamed, you'll only see "close". It's not ideal; solution would be to either add the word project to the other actions (i.e. "new" -> "new project", etc.), or find a way for the locator to append the menu / sub-menu string to the action (for e.g. "Project -> Close").

@nirvn
Copy link
Contributor

nirvn commented May 11, 2018

Sorry, forgot to mention that's I'm an overall +1 for this change.

@nyalldawson
Copy link
Collaborator Author

On the "close project" -> "close" action renaming, I have no problem with that, but it does highlight a tiny bit of an issue with the locator bar's way of handling shortcuts. ATM, if you type ". close" in the locator bar, you'll see the "close project" action. If it's renamed, you'll only see "close". It's not ideal; solution would be to either add the word project to the other actions (i.e. "new" -> "new project", etc.), or find a way for the locator to append the menu / sub-menu string to the action (for e.g. "Project -> Close").

Maybe locator should add the tooltip in brackets (if it's different to the action text)?

I'm not sure how I feel about save map as image/PDF... action being in the import/export sub-menu. I get why it makes sense for those to be there, and maybe it's just the habit of having used those so many times before it's hard to see those anywhere else. Maybe changing the wording to "Export Map as Image..." would make the actions sit better there?

Yeah, "Export to Image" would also add consistency. I'll do that.

@nirvn
Copy link
Contributor

nirvn commented May 11, 2018

Maybe locator should add the tooltip in brackets (if it's different to the action text)?

That sounds like a good approach, I'd be fine with that.

@nyalldawson
Copy link
Collaborator Author

@nirvn done

@nirvn
Copy link
Contributor

nirvn commented May 11, 2018

@nyalldawson , nice, +1 to merge, with the hope you'll execute a similar cleanup with the edit and view menus too 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants