-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes syncDb() that improperly sets "Imported from GDAL" as name for all GEOCCS #7009
Conversation
…all GEOCCS Allow syncDb() to properly set the name of each Geocentric Coordinate System ("GEOCCS") imported in srs.db from GDAL *.csv support files during postinstall, instead of wrongly setting it to "Imported from GDAL". Fixes #18968
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! Could you add a unit test checking the name of one of the affected crs?
hi @nyalldawson |
That's fine - I'll add one of you can advise me of some crs which are fixed by this issue? |
Thanks @nyalldawson |
7576ae1 also updates the descriptions. With GDAL 2.3 this leaves no rows with 'Imported from GDAL', but 72 with GDAL 2.2. So a test probably must be dependant on the GDAL versions. |
It's great to also update the description, so it shouldn't be necessary to "manually" fix srs.db! |
@agiudiceandrea Because they also didn't exist in GDAL 2.2 |
@agiudiceandrea can this (and #7011 ) be safely closed now? |
@jef-n I've just tested QGIS 3.1.0-21 weekly snapshot (310bfb1) (with GDAL 2.2.4) on Windows and it seems all ok for me: The 72 crs you previously mentioned (I see them in srs-template.db in the last qgis-providers-common deb package) are all in esri_extra.wkt, that seems missing in gdal-data deb package on Linux: so now they have a proper name on Windows but non on Linux. |
@agiudiceandrea The license of the wkt files were clarified and will be included in the debian packages of 2.3. |
Like for PR #6153, this commit allow syncDb() to properly set the name of each Geocentric Coordinate System ("GEOCCS") imported in srs.db from GDAL *.csv support files during postinstall, instead of wrongly setting it to "Imported from GDAL".
The bug is also in 3.0 and master.
Fixes #18968
Description
Include a few sentences describing the overall goals for this PR (pull request). If applicable also add screenshots.
Checklist
fixes #11111
in the commit message next to the description[FEATURE]
in the commit message[needs-docs]
in the commit message and contain sufficient information in the commit message to be documentedscripts/prepare-commit.sh
script before each commit