Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update currently edited feature in attribute table when selection changes #7015

Merged

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented May 17, 2018

It's a very common pitfall for people to toggle the selection instead of
the edit selection in the form view of the attribute table. I've noticed
clicking people repeatedly on the list because they know it's not
reliably going to give them what they want.

This change updates the active feature in the form view on a selection
change if one of the selected entries is visible in the current filter.

…nges

It's a very common pitfall for people to toggle the selection instead of
the edit selection in the form view of the attribute table. I've noticed
clicking people repeatedly on the list because they know it's not
reliably going to give them what they want.

This change updates the active feature in the form view on a selection
change if one of the selected entries is visible in the current filter.
@m-kuhn m-kuhn added this to the 3.2 milestone May 17, 2018
@m-kuhn
Copy link
Member Author

m-kuhn commented May 18, 2018

I'm aware this is quite short term.
I hope it's ok for everyone to merge this before freeze and I'll make sure it's fixed in case there are troubles!

@m-kuhn m-kuhn merged commit ae89b4f into qgis:master May 18, 2018
@m-kuhn m-kuhn deleted the ensureEditSelectionOnFeatureSelectionChange branch May 18, 2018 10:41
@elpaso
Copy link
Contributor

elpaso commented Jun 4, 2018

@m-kuhn I'm afraid this crashes when the layer is removed when the dialog is open (or docked) https://issues.qgis.org/issues/19054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants