SVG icons for settings

[3nids]

Following last discussion, here is a new set for the settings:

[timlinux]

There is still a log of visual incongruity in these icons. Some are glossy and some are flat and matte. It would be nice to try address this (probably in the direction of 'flatter and matter'). Perhaps this is one case where throwing out all the icons and starting from a clean slate might produce a more consistent result rather than trying to work with what is already there.

It would also be nice if the colours were in general consistent with those of the mainwindow icons.

Regards

Tim

[mach0]

Maybe Robert has time to jump in at that point and make the suggestions
compatible to his set.. Or the other way round ;-)

Sent from a rooted and thus truly free mobile device...
Am 08.07.2013 16:42 schrieb "Tim Sutton" notifications@github.com:

There is still a log of visual incongruity in these icons. Some are glossy
and some are flat and matte. It would be nice to try address this (probably
in the direction of 'flatter and matter'). Perhaps this is one case where
throwing out all the icons and starting from a clean slate might produce a
more consistent result rather than trying to work with what is already
there.

It would also be nice if the colours were in general consistent with those
of the mainwindow icons.

Regards

Tim

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/706#issuecomment-20609986
.

[dakcarto]

Hi Denis,

-1 from me now. I don't understand what the goal of most of your work is here in this dialog. There was nothing wrong with several of the icons you are now replacing with different styles, excepting that they were only in PNG format. If the goal is convert to SVG then just vectorize the existing non-SVG icons as is, trying to use existing GIS theme OSGeo graphics when possible (as I recently did with the CRS icon).

IMO it is very late in the schedule of releasing 2.0 to be introducing a different style. We should be focusing on fixing existing issues, e.g. like you have done with the 'add layer' icons, or just doing SVG conversions.

When I reworked your recent selection icons (commit 4516fad) I did so because they appeared to be created using a completely new style of artwork, and not based off of existing GIS theme components at all. If you have not, please checkout a local copy of the complete contents of the OSGeo graphics repo. There are many more icons in SVG from Robert that are not in the QGIS branch.

For example, there is clearly a SVG database icon in the repo that could have been directly used for the 'Data sources' setting section icon (though not sure that is the right icon since not all sources are databases, per se).

My opinion now is that these new settings icons be either abandoned (and the old ones reinstated as vectorized SVG) or made to be consistent with GIS theme palette. More to the point:

1. The previous General icon was just fine. It should be reinstated as it is used in other aspects of the GIS theme.
2. The new System icon is good, but should be built off of a vectorized wrench from the GIS theme (the yellow/orange-handled one).
3. Data sources icon as noted above
4. Digitizing and Map tools icons are a slight improvement and should probably stay.
5. Locale and Network icons. New style is not an improvement over previous one and introduces more inconsistency. The old icons should just be converted to SVG.

[anitagraser]

-1 for an inconsistent icon set. I'd rather have a consistent set with a few weak icons than a set with good individual icons where nothing fits together.
Larry summed it up for me.

[mach0]

On 07/08/2013 10:15 PM, anitagraser wrote:

-1 for an inconsistent icon set. I'd rather have a consistent set with a few weak icons than a set with good individual icons where nothing fits together.
Larry summed it up for me.

---

Reply to this email directly or view it on GitHub:
#706 (comment)

Agree with Larry and Anita..

But I think when it comes to graphic design .. Well .. Tastes are
different .. At one time we just have to take something ..
But I fully agree with Anita and Larry in
"I'd rather have a consistent set with a few weak icons"

Thanks for all the hard work Denis.. It's not an easy task you have
chosen here..

[Cracert]

Denis,
My main problem (re)designing icons is to not change good ideas to better ones too often. It will be nicer in some places, but difficult to follow by the user. And the problem in not only how, but also what to draw. It can look nicer, but must follow other parts of the interface.
Your 'general' icon is probably the best one in this set, but is inconsistent with the others.

For me the optimal workflow for settings icons is:

• discuss on monochrome mock-ups what to draw,
• draw it all in consistent manner (one person or more)

[3nids]

OK.
First, thank you all for your comments.
I understand your point, and in many ways I share them.
Anyway, I don't have enough time left to take care of this. I thought the add layers icons were almost finished, but it seems to be endless.
Therefore, I suggest to close this pull request and to revert to the old icons.
I am sorry for the mess.

[timlinux]

Hi

I think the new layer icons are the one thing from all these
discussions that would be worth spending the time to implement - even if we
can convince Robert to take your latest mockups and incorporate the ideas
into the QGIS theme while still preserving homogenity with the other icons.

Regards

Tim

On Tue, Jul 9, 2013 at 8:15 AM, Denis Rouzaud notifications@github.comwrote:

OK.
First, thank you all for your comments.
I understand your point, and in many ways I share them.
Anyway, I don't have enough time left to take care of this. I thought the
add layers icons were almost finished, but it seems to be endless.
Therefore, I will close this pull request and I suggest to revert to the
old icons.
I am sorry for the mess.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/706#issuecomment-20655388
.

Tim Sutton - QGIS Project Steering Committee Member (Release Manager)

Visit http://linfiniti.com to find out about:

• QGIS programming services
• GeoDjango web development

• FOSS Consulting Services
  Skype: timlinux Irc: timlinux on #qgis at freenode.net

[Cracert]

Denis,

As Tim wrote - layer icons are almost ready and look better than existing ones.
In such huge community completely different points of view are normal. This makes QGIS project so strong. Let's discuss, draw and don't give up - we need you ...

[m-kuhn]

It is really nice work you did here!
I would very much appreciate giving these icons missing bits (which is not much) and using these new icons instead of reverting to the old ones.

[3nids]

Thanks for your comments.
I will wait for others request to get through and see how things are going.

[mhugent]

assigned to @dakcarto

[timlinux]

I suggest to close this without applying - the options dialogs are looking pretty good now with Nathan's tweaks and I don't think these changes are cohesive enough.

[anitagraser]

+1 to close as @timlinux suggests

[3nids]

good for me