Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8219 #709

Closed
wants to merge 9 commits into from
Closed

Fix #8219 #709

wants to merge 9 commits into from

Conversation

ddanielvaz
Copy link
Contributor

fixes the file doGeoprocessing.py (#8219)
fixes the file doIntersectLines.py (#7073)

@@ -561,10 +556,6 @@ def convex_hull(self, useField ):
try:
outGeom = tmpGeom.convexHull()
outFeat.setGeometry( outGeom )
(area, perim) = self.simpleMeasure( outGeom )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I am not entirely familiar with QGis, but line 564 until 567 adds some fields in the feature (area, perimeter and outId). When I remove these lines, the fields area and perimeter still exists (when I click in the added feature, using the info tool, these fields are showed for me).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ones in the info tool are generated on the fly. These are added as attributes on each feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will restore it. I am in trouble with git, sorry. I will try to clean up the messy when I return to my home.

@NathanW2
Copy link
Member

See comment on #702 for close reason.

@NathanW2 NathanW2 closed this Jul 10, 2013
@ddanielvaz ddanielvaz deleted the fix-issue-8219 branch July 10, 2013 11:28
@ddanielvaz ddanielvaz restored the fix-issue-8219 branch July 10, 2013 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants