Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fill/stroke parameters to some North Arrows svg images #7139

Merged
merged 2 commits into from Jun 1, 2018
Merged

Adds fill/stroke parameters to some North Arrows svg images #7139

merged 2 commits into from Jun 1, 2018

Conversation

agiudiceandrea
Copy link
Contributor

@agiudiceandrea agiudiceandrea commented Jun 1, 2018

Description

  • Adds fill parameter to N,S,E,W letters of NorthArrow_07.svg
  • Adds fill/stroke parameters for star and dashed arc of NorthArrow_08.svg
  • Adds fill/stroke parameters for star and dashed arc of NorthArrow_09.svg

This allows to change the color of letters, star and dashed arc of the above mentioned north arrow svg images that otherwise remain always black.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

- Adds fill parameter to N,S,E,W letters of NorthArrow_07.svg
- Adds fill/stroke parameters for star and dashed arc of NorthArrow_08.svg
- Adds fill/stroke parameters for star and dashed arc of NorthArrow_09.svg
@nirvn
Copy link
Contributor

nirvn commented Jun 1, 2018

You will also need to add the fill and stroke opacity params.

NorthArrow_07.svg, NorthArrow_08.svg, NorthArrow_09.svg
@nirvn nirvn merged commit 6192b5e into qgis:master Jun 1, 2018
@nirvn
Copy link
Contributor

nirvn commented Jun 1, 2018

@agiudiceandrea , thanks for this contribution.

@agiudiceandrea agiudiceandrea deleted the fix_north_arrows_parameters branch June 1, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants