Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[layouts] Save last used export folder in project #7298

Merged
merged 9 commits into from
Jun 22, 2018

Conversation

nyalldawson
Copy link
Collaborator

And use it in preference to the global last used export folder.

Because GIS use is typically specific project based, and it makes little sense to default to an output folder related to a different project. In fact, it's REALLY REALLY annoying to keep resetting the default export folder to some other project's export folder.

existing folder match for a path

E.g. if \a path is "/home/user/projects/2018/P4343"
and "/home/user/projects" exists but no "2018" subfolder
exists, then the function will return "/home/user/projects".

(Suprisingly no existing Qt method for this!)
And use it in preference to the global last used export folder.
Because GIS use is typically specific project based, and it makes
little sense to default to an output folder related to
a different project.
@nyalldawson nyalldawson added this to the 3.2 milestone Jun 22, 2018
@nyalldawson
Copy link
Collaborator Author

(I think we should probably do something similar to this with layer exports and processing outputs too)

@nirvn
Copy link
Contributor

nirvn commented Jun 22, 2018

I like this idea. However I'm not sure it'll play well for projects that are shared amongst more than one user (mind you there are many other areas that don't pay well either).

What about saving the last folder in the user settings, and have keys for each project files.

Ie value( "/UI/layout/lastExportFolder/myproject_name" ).

+1 to expand to other areas too (export map canvas as image / PDF, processing stuff, etc).

@nyalldawson
Copy link
Collaborator Author

I like this idea. However I'm not sure it'll play well for projects that are shared amongst more than one user (mind you there are many other areas that don't pay well either).

Actually that's intentional too - if the path doesn't exist, it falls back gracefully to the older behaviour.

@nyalldawson
Copy link
Collaborator Author

I'll hold this PR off until 3.2.1, just to be safe.

@m-kuhn do you know why I can't edit the available milestones? I'd like to add 3.2.1, etc...

@m-kuhn
Copy link
Member

m-kuhn commented Jun 22, 2018

Hmmm... I add them here https://github.com/qgis/QGIS/milestones

@nyalldawson nyalldawson modified the milestones: 3.2, 3.2.1 Jun 22, 2018
@m-kuhn m-kuhn merged commit 2718317 into qgis:master Jun 22, 2018
@nyalldawson nyalldawson deleted the layout branch June 29, 2018 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants