String length constraints-postgis

[shivareddyiirs]

Bug fixes #19213
PostGIS error while adding features: ERROR: value too long for type character varying(50)

Description

Since in the DB Manager Plugin there is no GUI option to set this option , I have updated the option dict to remove string length constraint.
Bug fixes #19213

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

• Commit messages are descriptive and explain the rationale for changes
• Commits which fix bugs include fixes #11111 in the commit message next to the description
• I have read the QGIS Coding Standards and this PR complies with them
• This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
• I have run the scripts/prepare-commit.sh script before each commit

[nyalldawson]

Thanks for sending this fix!

I'm curious though as to how this situation arises. My understanding is that the field length here is taken direct from the source layer. So this would hint that somehow your layer has an incorrect length for this field. This would point to a deeper underlying issue.

What data format is your layer? Can you identify if indeed there is an incorrect string field length here?

[shivareddyiirs]

Yes it is taken from source layer but there is upper limit i.e. 50 by default. But in my case I storing file address in the field. I have attached sample data in the raised issue. It is shapefile. ‘Import to PostGIS’processing tool gives user to check/ uncheck this option. But in DB manager UI has no such option and that’s why I set this option by default. I don’t suggest any change in the GUI of DB Manager now. Why this restriction is there in first place, I also don’t know?

…

Sent from my iPhone

On 23-Jun-2018, at 12:46 AM, Nyall Dawson ***@***.***> wrote: Thanks for sending this fix! I'm curious though as to how this situation arises. My understanding is that the field length here is taken direct from the source layer. So this would hint that somehow your layer has an incorrect length for this field. This would point to a deeper underlying issue. What data format is your layer? Can you identify if indeed there is an incorrect string field length here? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[shivareddyiirs]

I checked with varying field length, But whenever there is entry in the field which is longer than 50 , it gives same error.

[shivareddyiirs]

@nyalldawson
I request to fix this bug in 3.2 release iteself. I would be able to use it in the course starting in july

[shivareddyiirs]

Sorry for inconvenience. But I think there was some problem in my data itself.
I checked and its working fine now. Since I created attribute using pyqgis library and set length as 50 but my plugin while adding attribute value stored longer values.

I am closing this pull request and and also the issue I reported.
@nyalldawson Now I can comprehend, there is deeper underlying issue (may be in pyqgis layer editing API)

Once Again Thanks

[nyalldawson]

No problem! This was on my TODO to investigate, so thanks for crossing an item off that list 👍