Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input parameters of SAGA processing algorithms #7394

Closed
wants to merge 2 commits into from

Conversation

rudivs
Copy link
Contributor

@rudivs rudivs commented Jul 10, 2018

Description

Update SAGA SnapPointstoLines and SnapPointstoPoints to have the correct input parameter types. Currently 'snap points to lines' only has lines in the points input dropdown and has both points and lines in the lines snap dropdown. This PR changes the parameter type of the points input to only list point layers, and the lines input to only list line vector layers.

The 'snap points to points' algorithm allows both lines and points in both dropdowns. This PR sets the parameter type for both dropdowns to be point vector layers only.

Fixes #19382 (https://issues.qgis.org/issues/19382)

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@rudivs
Copy link
Contributor Author

rudivs commented Jul 10, 2018

I checked in 2.18 and it was a bug there too, so I guess this needs backporting?

@rudivs
Copy link
Contributor Author

rudivs commented Jul 10, 2018

Test failure from unrelated PyQgsOfflineEditingWFS.

@nyalldawson
Copy link
Collaborator

@rudivs

Thank you! I'll add a unit test to this branch too shortly.

@rudivs
Copy link
Contributor Author

rudivs commented Jul 10, 2018

Thanks @nyalldawson! I took a look at the saga tests but couldn't figure it out.

@nyalldawson
Copy link
Collaborator

Thanks @rudivs - #7400 adds unit tests to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants