Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #19824 where modifications to project models were not saved #7865

Merged
merged 2 commits into from
Sep 15, 2018

Conversation

olivierdalang
Copy link
Contributor

Description

Fix #19824 where modifications to project models were not saved.

The fix includes a small refactoring to use a dict instead of a list to store the algorithms in the project provider. This makes it easier to get a reference to the algorithm by name.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

Models definitions are now stored in a dict rather than list
which allows for less verbose code to reference models by name
@nyalldawson
Copy link
Collaborator

Thanks! Can you please add a unit test covering this to python/plugins/processing/tests/ProjectProvider.py ?

@pblottiere pblottiere added Requires Tests! Waiting on the submitter to add unit tests before eligible for merging Bugfix labels Sep 12, 2018
@nyalldawson
Copy link
Collaborator

Test looks good! It just needs running through the scripts/prepare-commit.sh script in order to correct the formatting

@nyalldawson nyalldawson added this to the 3.4.0 milestone Sep 15, 2018
@nyalldawson nyalldawson merged commit 77d7d66 into qgis:master Sep 15, 2018
@olivierdalang olivierdalang deleted the fix_save_in_project_overwrite branch September 15, 2018 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Requires Tests! Waiting on the submitter to add unit tests before eligible for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants