[Server] Print an error message, on project load error #8006

sbrunner · 2018-09-24T14:33:46Z

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

Commit messages are descriptive and explain the rationale for changes
Commits which fix bugs include fixes #11111 in the commit message next to the description
Commits which add new features are tagged with [FEATURE] in the commit message
Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
I have read the QGIS Coding Standards and this PR complies with them
This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
New unit tests have been added for core changes
I have run the scripts/prepare-commit.sh script before each commit

m-kuhn · 2018-09-24T14:54:45Z

src/server/qgsconfigcache.cpp

@@ -47,6 +47,10 @@ const QgsProject *QgsConfigCache::project( const QString &path )
      mProjectCache.insert( path, prj.release() );
      mFileSystemWatcher.addPath( path );
    }
+    else
+    {
+      QgsMessageLog::logMessage( "Error, project file '"  + path + "': " + prj->error(), QStringLiteral( "Server" ), Qgis::Critical );


Better translate this and use a template based approach.

tr( "Error when loading project file '%1': %2 " ).arg( ... )

I don't see any translated log message on QGIS server, and I think that better to keep it like it...

But any messages coming from the qgis_core library will be translated. So it's expected to have a mix of translated and untranslated messages in the server logs? Sorry to open up this question here ;) Any other server devs with an opinion on this matter (@rldhont @elpaso @dmarteau others?)

I think that error messages should be translated, but not OGC exceptions (defined as is in the standard).

OK..., Than I will do it :-)

Updated :-)

Thanks. Now for the fun part, arg() takes multiple parameters and is more performant in this case so it's good practice to use it

OK, thanks, updated :-)

m-kuhn reviewed Sep 24, 2018

View reviewed changes

sbrunner changed the title ~~Print an error message, on project load error~~ [Server] Print an error message, on project load error Sep 25, 2018

sbrunner force-pushed the print-error branch 3 times, most recently from bd45a05 to 8f45f20 Compare September 25, 2018 08:38

Print an error message, on project load error

5f33137

sbrunner force-pushed the print-error branch from 8f45f20 to 5f33137 Compare September 25, 2018 11:22

rldhont approved these changes Sep 25, 2018

View reviewed changes

sbrunner merged commit 981aea7 into qgis:master Sep 25, 2018

sbrunner deleted the print-error branch September 26, 2018 07:43

rldhont mentioned this pull request Sep 26, 2018

[Bugfix][Server] Add WMS SLD parameter support #7859

Merged

6 tasks

qgib mentioned this pull request May 25, 2019

Add support for multi-line strings in the composer' attribute table item #18705

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Server] Print an error message, on project load error #8006

[Server] Print an error message, on project load error #8006

sbrunner commented Sep 24, 2018 •

edited

m-kuhn Sep 24, 2018

sbrunner Sep 25, 2018

m-kuhn Sep 25, 2018

pblottiere Sep 25, 2018

sbrunner Sep 25, 2018

sbrunner Sep 25, 2018

m-kuhn Sep 25, 2018

sbrunner Sep 25, 2018

[Server] Print an error message, on project load error #8006

[Server] Print an error message, on project load error #8006

Conversation

sbrunner commented Sep 24, 2018 • edited

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbrunner commented Sep 24, 2018 •

edited