[server] Fixes freeze of server during rendering #8228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tudorbarascu Can you check that your issue is fixed with this fix? |
m-kuhn
reviewed
Oct 18, 2018
| @@ -56,6 +56,13 @@ namespace QgsWms | |||
| renderJob.setFeatureFilterProvider( mFeatureFilterProvider ); | |||
| #endif | |||
| renderJob.start(); | |||
|
|
|||
| // Allows the main thread to manage blocking call coming from rendering | |||
| // threads (see discussion in #18988). | |||
There was a problem hiding this comment.
Better add a link here, we will sooner or later have a collision with pull request numbers.
|
Looks good to me if that fixes the issue |
|
@pblottiere It's fixed with this commit, yes! Thank you! |
pblottiere
force-pushed
the
server_deadlock
branch
from
57ce5f1
to
ef4bf1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Debian Buster, the server is freezing when parallel rendering is activated.
See #8063 (comment).
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and contain sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit