-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #19703, make filter translatable and add NetCDF #8245
Conversation
Note that grepping for Also it looks like for the qfiledialog the preferred way to filter is not the extension anymore but the 'mimetype filters'. Not sure what happens when you set both. I was not sure if I had to put it on the end of the filters, if I'm right there is a convention that on OPENING dialogs the All Files filter is to be put as first, while in SAVING it is put as last (and the first one is the preferred format). Right? Also wondering about the translatability. I just put the whole file filter in the tr() function, while I also see places where a dev split up the filter string in parts and then choose to make those translatable or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't there be a space before each '('?
@nyalldawson yep you are right, added. And also had a look at the Apple HIG guidelines on how combobox text labels should be capitalized: https://developer.apple.com/design/human-interface-guidelines/macos/fields-and-labels/combo-boxes/ So also used Title Case for the other strings. Notes for > 3.4 (?) would be nice to do a mass edit of all the filters in QGIS, to:
|
merged |
Description
This fixes https://issues.qgis.org/issues/19703 where files without an extension were not show in the Open Mesh dialog.
Additionally the filter string is translatable.
And I added NetCDF (*.nc) files to filter list (which is working for me here, but beter @PeterPetrik checks if this is really the case).
Checklist
fixes #11111
in the commit message next to the description[FEATURE]
in the commit message[needs-docs]
in the commit message and contain sufficient information in the commit message to be documentedscripts/prepare-commit.sh
script before each commit