vector layer properties now checks if config widget factory supports layer (fixes #20240) #8366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…layer previously the factory would always be used, even if it did not support the active layer fixes qgis#20240
ricardogsilva
changed the title
nyalldawson
approved these changes
Oct 29, 2018
|
Thanks @ricardogsilva, nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #20240
The layer properties dialog now explicitly checks if the config widget factory supports the current layer. The relevant
supportsLayermethod was already in theQgsMapLayerConfigWidgetFactory's API, it just wasn't being used in the rest of the code.Checklist
fixes #11111in the commit message next to the descriptionscripts/prepare-commit.shscript before each commit