[wms] Do not pass null QStrings to QgsWmsProvider::setQueryItem #8388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix qgis#20271 - WMS is not displayed in QGIS 3.4.0 With test
nyalldawson
reviewed
Oct 31, 2018
src/providers/wms/qgswmsprovider.cpp
Outdated
| @@ -482,7 +482,10 @@ bool QgsWmsProvider::setImageCrs( QString const &crs ) | |||
| void QgsWmsProvider::setQueryItem( QUrl &url, const QString &item, const QString &value ) | |||
| { | |||
| url.removeQueryItem( item ); | |||
| url.addQueryItem( item, value ); | |||
| if ( value.isNull() ) | |||
| url.addQueryItem( item, QStringLiteral( "" ) ); | |||
There was a problem hiding this comment.
No: that is exactly the source of the problem: a null string will trigger the error.
There was a problem hiding this comment.
I don't know exactly when the problem appeared, the fact is that QString().isNull() == true and that's exactly the source of the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20271 - WMS is not displayed in QGIS 3.4.0
With test