bad layers dialog new button labels and icon #8435
Conversation
|
Proposal |
This comment has been minimized.
This comment has been minimized.
|
Ok, I think we need to insure browse and apply are paired together (separating them like the shot above is counterintuitive My suggestion would be to move browse and apply to be left end and have the remove & keep buttons at the right end. |
|
@elpaso , how are things look like now? |
|
Looks good, see the new picture |
|
I just want to add a small fix on "Change data source..." and disable it when layer is editable, then I'll merge |
|
@elpaso , nice, undeniable improvement. |
|
@elpaso , any chance you could tweak the layer menu order: IMHO, open attribute table should be a the top of the menu section, followed by toggle editing. I don't have strong feelings as to whether filter or change data source should come first. |
I would say |
|
@DelazJ , yeah, that's where my vote would go on the ballot too. |
|
Anybody can provide a nice icon for that action? |
|
@elpaso , IMHO, it's a good candidate for an icon-less action. |
| @@ -200,15 +200,23 @@ QMenu *QgsAppLayerTreeViewMenuProvider::createContextMenu() | |||
| menu->addSeparator(); | |||
|
|
|||
| // change data source is only supported for vectors and rasters | |||
| if ( vlayer || rlayer ) | |||
| if ( ( vlayer || rlayer ) ) | |||
There was a problem hiding this comment.
Are these extra parentheses on purpose?
| menu->addAction( a ); | ||
| // Disable when layer is editable |
There was a problem hiding this comment.
If this comment needs to stay I think it should go to line 208
Followup #8359 (comment)
@SrNetoChan @nirvn what do you think?