[project] Avoid needlessly dirtying when written value does not change #8470
Conversation
nirvn
changed the title
|
Upon advise from @nyalldawson , I went for a lower level solution, which avoids needless dirtying of project in other parts of QGIS (for e.g., for an impractical example: opening and closing a decoration dialog won't dirty the project if none of the settings are modified). |
|
Note: it also improves the way isDirtyChanged is emitted, whereas before it was a/ emitted prior to the entry was written, and b/ emitted irrespective of whether the entry was actually written. |
...and that's why you make the big bucks ;) |
nirvn
force-pushed
the
designerpath
branch
2 times, most recently
from
c1995e8
to
f8c4ee2
Compare
|
@nyalldawson , OK to merge (and backport) upon travis turning green? |
|
Better leave it a day or so for wider feedback, QgsProject is critical stuff |
|
@wonder-sk , @m-kuhn , your review would be appreciated here. |
| */ | ||
| QgsProjectProperty *addKey_( const QString &scope, | ||
| const QString &key, | ||
| QgsProjectPropertyKey *rootProperty, | ||
| const QVariant &value ) | ||
| const QVariant &value, | ||
| bool &propertiesModified ) |
There was a problem hiding this comment.
why not use directly setDirty inside addKey_ when necessary?
There was a problem hiding this comment.
@luipir , because we'd have to pass on a QgsProject pointer to do that, which doesn't seem to be a good idea to begin with :)
There was a problem hiding this comment.
has ok, I supposed addKey_ was a private QgsProject member, sorry for the noise
|
Looks good to me |
Description
@nyalldawson , this PR avoids needlessly dirtying project when exporting a layout by checking if the export path is modified instead of always re-writing the last export path into the project.
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and contain sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit