Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGIS testing environment docker backport #8577

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Nov 30, 2018

No description provided.

@elpaso elpaso added this to the 3.4.3 milestone Nov 30, 2018
@elpaso elpaso merged commit 3462721 into qgis:release-3_4 Dec 3, 2018
@elpaso elpaso deleted the docker-testing-env-backport-2 branch December 3, 2018 07:34
@m-kuhn
Copy link
Member

m-kuhn commented Dec 3, 2018

Looks like it all works fine after the updates still in our CI, nice. Sorry I got only around to test today.

@Gustry
Copy link
Contributor

Gustry commented Dec 3, 2018

Yes, the image latest is working for CI, waiting tonight the 3.4 tag

@m-kuhn
Copy link
Member

m-kuhn commented Dec 3, 2018

@Gustry I was referring to #8500 (comment) . We are using these images for quite long already in travis-ci for unit tests and wanted to be sure it continues to work for unit tests also with the current improvements for integration tests.

@Gustry
Copy link
Contributor

Gustry commented Dec 5, 2018

Do you know when the tag 3.4 will be updated? It's still the old image from 3 days ago.
https://hub.docker.com/r/qgis/qgis/tags/

@3nids
Copy link
Member

3nids commented Dec 5, 2018

this PR has broken the builds of the images
see 3462721#r31568287

@elpaso
Copy link
Contributor Author

elpaso commented Dec 5, 2018

@3nids maybe I forgot to backport this: https://github.com/qgis/QGIS/blob/master/.dockerignore, despite I asked for them, I don't have credentials for docker hub or travis so I cannot inspect how it's implemented or trigger a build to fix it, sorry if I cannot help more.

@3nids
Copy link
Member

3nids commented Dec 5, 2018

I don't think the credentials for docker hub or travis are the issue here.

you have the error in log:

Removing intermediate container 76cc1314e92f
Step 15/21 : COPY .docker/qgis_resources/test_runner/qgis_* /usr/bin/
COPY failed: no source files were specified

@elpaso
Copy link
Contributor Author

elpaso commented Dec 5, 2018

Sorry if I wasn't clear, let me try to rephrase: I believe that the issue is that in .dockerignore there is a rule to ignore .*, what I'm saying is that I would have verified and fixed it myself without bothering you if I would have had those credentials.

@elpaso
Copy link
Contributor Author

elpaso commented Dec 5, 2018

btw, I'm currently building the docker locally and see it that was the issue (I cannot see any other reason: the files to copy are there, just docker seems to ignore them).

@3nids
Copy link
Member

3nids commented Dec 5, 2018

sorry too, not following.
This has to be fixed in QGIS source, am I right?
Which credentials would have helped here? If I am not wrong, you don't need the credentials to see the tags of the images on docker hub nor the Travis ones to see the logs.
(but I'm not saying you should not get the credentials, that's not my decision, but rather trying to understand the issue here)

@elpaso
Copy link
Contributor Author

elpaso commented Dec 5, 2018

sorry too, not following.
This has to be fixed in QGIS source, am I right?

Yes, but, forgive my ignorance because I really don't know, there is a cron job that build the images on travis, correct?
Is it documented anywhere?
Where is it configured? Is it in QGIS git sources?
Because if it's not, the missing bit here is the cron job and I have no idea about how/where/what/when it runs, AFAIK it's on Travis and only admins can see/change it.

So, If I need to autonomously fix it, I would need not only to patch QGIS git sources but ALSO to trigger a build on Travis and check that everything run smoothly. <--- here is when I need the credentials.

Otherwise all I can do is react on your notice that the builds are broken, try to fix them locally and push changes on QGIS repo and then sit and wait.

Am I completely wrong here?

@elpaso
Copy link
Contributor Author

elpaso commented Dec 5, 2018

@3nids btw I pushed the fix on release-3_4 now I can sit and wait :)

@3nids
Copy link
Member

3nids commented Dec 5, 2018

so sorry, got it!!!
Indeed, cron jobs are run daily on master and release-* branches....
Although you can not configure them, you should be able to see them in the build history, they are clearly marked as cron.
I've just retriggered cron build on 3.4, so you should see it on top of list now.

The cron jobs are indeed configured in Travis settings. The best/only documentation available is actually .travis.yaml which says what it does on cron jobs.

So we were both partially right ... or wrong :)

To get credentials, I think you can ask Tim or PSC.

@3nids
Copy link
Member

3nids commented Dec 5, 2018

this seems fixed, thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants