opencl rastercalc fix int input rasters and cast to float #8666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cast to float all math operations because when the input is not a float or a double opencl raises an error regarding which override should pick. By casting to float we are sure that the right function will be called. This patch also fixes the buffer sizes for short (16bit) and int (32bit) and asserts that siexe of float is 32bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast to float all math operations because when the
input is not a float or a double opencl raises
an error regarding which override should pick.
By casting to float we are sure that the right
function will be called.
This patch also fixes the buffer sizes for short (16bit)
and int (32bit) and asserts that size of float is 32bit.
Also fixes the case when there is no input raster at all
and the calculation is only expression based.