Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show feedback message when using Select by Expression #8805

Merged
merged 3 commits into from
Jan 8, 2019

Conversation

nyalldawson
Copy link
Collaborator

(to match Select by Form behaviour)

@nyalldawson nyalldawson added the UX label Jan 8, 2019
@nyalldawson nyalldawson added this to the 3.6 milestone Jan 8, 2019
@nirvn
Copy link
Contributor

nirvn commented Jan 8, 2019

The message times out after X seconds right? I can't remember the pushMessage(...) default here.

If it doesn't, please make it so :) all good otherwise.

@nyalldawson
Copy link
Collaborator Author

The message times out after X seconds right?

Yep

@nirvn
Copy link
Contributor

nirvn commented Jan 8, 2019

+1 to merge.

@nyalldawson nyalldawson merged commit 4da0796 into qgis:master Jan 8, 2019
@nyalldawson nyalldawson deleted the expression_select branch January 8, 2019 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants