Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processing] do not allow editing model if it's missing algorithms #8957

Merged
merged 2 commits into from
Jan 24, 2019
Merged

[processing] do not allow editing model if it's missing algorithms #8957

merged 2 commits into from
Jan 24, 2019

Conversation

volaya
Copy link
Contributor

@volaya volaya commented Jan 23, 2019

fixes #19607

Description

When editing a model that includes unavailable algorithm, an error trace is shown. With this fix, the exception is captured and a nicer message is shown

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

Co-Authored-By: volaya <volayaf@gmail.com>
@m-kuhn m-kuhn merged commit 7482f7a into qgis:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants