Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash when print from qgis processing algorithm while the python console is displayed #9019

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

troopa81
Copy link
Contributor

Description

If user use the method print inside a QgsProcessingAlgorithm and the python console is open, the application crashes. It's because when the console is opened, the print is caught and reported in the console through QScintilla, but GUI stuff has to be done is the main thread.

This PR use the Qt event loop to handle the print in the main thread.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@m-kuhn m-kuhn added the Bugfix label Jan 29, 2019
@m-kuhn m-kuhn added this to the 3.6.0 milestone Jan 29, 2019
@nyalldawson nyalldawson merged commit b82ce0e into qgis:master Jan 29, 2019
@troopa81
Copy link
Contributor Author

@nyalldawson does it need to be backported?

@m-kuhn
Copy link
Member

m-kuhn commented Jan 29, 2019

@nyalldawson does it need to be backported?

yes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants