Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] fix qgsRound for negative numbers. Fixes #20861 #9025

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

lbartoletti
Copy link
Member

Description

The round/qgsRound function returns a false result for negative numbers.

For example qgsRound( -1234.567, 2) should return -1234.57 and not -1234.56 (tested on python and postgis)

I added this test and corrected those on negative numbers.

Fixes #20861

cc @nyalldawson

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@nyalldawson nyalldawson merged commit cfdc8c2 into qgis:master Jan 29, 2019
@lbartoletti lbartoletti deleted the qgsRound_fix_neg_number branch February 22, 2019 15:26
@lbartoletti lbartoletti mentioned this pull request Jun 28, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants