Sip keep reference to registry #9112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If they are deleted, any other python wrappers which have been parented to these singletons are deleted too. One of the most common issues with this is, that subclasses of registry items are deleted and lost.
m-kuhn
force-pushed
the
sip-keep-reference-to-registry
branch
from
462b073
to
b2aed60
Compare
luipir
approved these changes
Feb 6, 2019
|
@m-kuhn i noticed you missed some registries here -- e.g. layoutItemRegistry, symbolLayerRegistry etc. Was this intentional or an oversight? I'm inclined to add this to ALL singletons, just to avoid annoyances in future if they gain registry like behaviour. |
|
Oops, I just quickly grepped for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding item to registries they are transferred to C++ via
/Transfer/.This adds an additional reference to the wrapper of the registered instance from the registry wrapper. If the registry wrapper scoped out, this reference was deleted and the child sip wrapper therefore garbage collected. By adding /KeepReference/ annotation to the registry accessors, the wrapper of the registries will never be deleted. This is no big deal, since they are de facto singletons.
The only slight shortcoming here is, that the python wrappers of registered items will never be garbage collected. But that should really only lead to minimal overhead.