Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapping options in meters rounded to integers (fixes #20829) #9168

Merged

Conversation

lbartoletti
Copy link
Member

Description

The widget add the tolerance before determining the unit and therefore whether it will be of integer or double type. As the default entry is on px, so integer, the tolerance is rounded. Changing the order solves the problem.

cc @mhugo

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@m-kuhn m-kuhn added the Bugfix label Feb 18, 2019
@m-kuhn m-kuhn changed the title [BUGFIX] fixes #20829 Snapping options in meters rounded to integers Snapping options in meters rounded to integers (fixes #20829) Feb 18, 2019
@nyalldawson nyalldawson merged commit 50c9b23 into qgis:master Feb 20, 2019
@lbartoletti lbartoletti deleted the bugfix_20829_snapping_rouding_integers branch February 22, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants