Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports #9192

Merged
merged 5 commits into from Feb 19, 2019
Merged

Backports #9192

merged 5 commits into from Feb 19, 2019

Conversation

mhugo
Copy link

@mhugo mhugo commented Feb 18, 2019

Description

Backports from master:

  • fix $length in labels
  • avoid an undefined behaviour

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

Hugo Mercier added 4 commits February 14, 2019 16:01
Use the project expression scope to access project
parameters (ellipsoid and distance/area units)
Look also for the attribute in the feature, as it is done by evalNode()
setGeomCalculator, setDistanceUnits and setAreaUnits have now
 precedence over expression scopes.
@nyalldawson
Copy link
Collaborator

+1 . Can you include 1b228bb also?

@mhugo
Copy link
Author

mhugo commented Feb 19, 2019

@nyalldawson Sure, and thanks for the addition

@mhugo mhugo merged commit db4bf52 into qgis:release-3_4 Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants