Processing: fix crash in alg runner task with bad scripts #9193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not crashing locally, wierd. |
|
@nyalldawson giving up here, I've tried another approach (that like the original one does not crash locally) but it's still crashing on Travis, is there anything on Travis that catches the Python exception and interferes with the execution of the test? |
Exposes the full Python exception when an error occurs in createInstance()
|
979adbb seems to fix it, plus gives better debugging messages |
|
@nyalldawson thanks! |
elpaso
added a commit
to elpaso/QGIS
that referenced
this pull request
Feb 20, 2019
…unner-crash Processing: fix crash in alg runner task with bad scripts Cherry-picked from master commit ff9a65c
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21270
With test