Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache unique values when creating features #9203

Merged
merged 20 commits into from
Feb 21, 2019
Merged

Cache unique values when creating features #9203

merged 20 commits into from
Feb 21, 2019

Commits on Feb 19, 2019

  1. Cache unique values in createFeature (~10x faster)

    @elpaso
    elpaso committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    f2e745e View commit details
    Browse the repository at this point in the history

  2. Cache unique values when creating features 

    Fixes qgis#21305 - pasting features is very slow

Aggressively optimize createFeature for speed
and introduces createFeatures for bulk creation.
    @elpaso
    elpaso committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    ba3d9ed View commit details
    Browse the repository at this point in the history

  3. Rename QgsFeaturesData to QgsFeatureData and fix test case

    @elpaso
    elpaso committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    490c1fe View commit details
    Browse the repository at this point in the history

  4. Fix docs for createFeatures

    @elpaso
    elpaso committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    348e683 View commit details
    Browse the repository at this point in the history

  5. Typo

    @elpaso
    elpaso committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    7fa9bc1 View commit details
    Browse the repository at this point in the history

  6. Fix unique values on GPKG pk 

    Fixes qgis#21311
    @elpaso
    elpaso committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    1689c93 View commit details
    Browse the repository at this point in the history

  7. Fix renamed QgsVectorLayerUtils.QgsFeatureData

    @elpaso
    elpaso committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    818611c View commit details
    Browse the repository at this point in the history

  8. Fix unique values on SQLite (OGR) pk

    @elpaso
    elpaso committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    5d7a7ac View commit details
    Browse the repository at this point in the history

  9. Explain why the workaround for GPKG/SQLite is necessary 

    I've talked to Even for this one
    @elpaso
    elpaso committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    f454827 View commit details
    Browse the repository at this point in the history

  10. Update src/providers/ogr/qgsogrprovider.cpp 

    Co-Authored-By: elpaso <elpaso@itopen.it>
    @m-kuhn @elpaso
    m-kuhn and elpaso committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    adba08c View commit details
    Browse the repository at this point in the history

  11. Update src/providers/ogr/qgsogrprovider.cpp 

    Co-Authored-By: elpaso <elpaso@itopen.it>
    @m-kuhn @elpaso
    m-kuhn and elpaso committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    7e008b2 View commit details
    Browse the repository at this point in the history

  12. Revert QStringLiteral

    @elpaso
    elpaso committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    11c9ce0 View commit details
    Browse the repository at this point in the history

  13. Fix unique values when generating a set of features

    @elpaso
    elpaso committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    d239ea2 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2019

  1. Update src/core/qgsvectorlayerutils.cpp 

    Co-Authored-By: elpaso <elpaso@itopen.it>
    @m-kuhn @elpaso
    m-kuhn and elpaso committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    f4d7e73 View commit details
    Browse the repository at this point in the history

  2. Revert "Update src/core/qgsvectorlayerutils.cpp" 

    This reverts commit f4d7e73.
    @elpaso
    elpaso committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    443d860 View commit details
    Browse the repository at this point in the history

  3. Moved comment

    @elpaso
    elpaso committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    4c8280a View commit details
    Browse the repository at this point in the history

  4. Prevent crash when fields are deleted from the vector options dialog

    @elpaso
    elpaso committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    76c6ec8 View commit details
    Browse the repository at this point in the history

  5. Also check for nulls when applying defaults 

    isValid is not enough because fields are initialized with
QVariant(field.type()) which is valid but null.

Fixes qgis#21304

With test
    @elpaso
    elpaso committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    bf1575f View commit details
    Browse the repository at this point in the history

  6. Test for regression qgis#21304 "default value" is not applied when pa… 

    …sting features
    @elpaso
    elpaso committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    2604fc7 View commit details
    Browse the repository at this point in the history

  7. Removed redundant check for isValid

    @elpaso
    elpaso committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    4250ef2 View commit details
    Browse the repository at this point in the history