Postgis: cache information about enum fields #9219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is called several times and can slow down substantially the opening of the attribute table. Partially fixes qgis#21303 (down from ~30 to ~6 seconds on a remote connection) The remaining ~4 seconds (compared to ~2 seconds in 2.18) are due to the check for enums and provider-side constraints, that were not implemented in 2.18. See: QgsEnumerationWidgetFactory::fieldScore and the call to enumValues for details, fieldScore is called several times because QgsAttributeTableModel::loadAttributes is also called multiple times and it queries for widget configuration all the times.
nyalldawson
reviewed
Feb 20, 2019
|
@elpaso brillant! tested it and at least in the use case where I first noticed the problem now it become usable again. |
|
any chance to have this backported? |
|
I think that the same considerations from #9203 apply here. |
ok, I understand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is called several times and can slow down substantially
the opening of the attribute table.
Partially fixes #21303 (down from ~30 to ~6 seconds on a remote
connection)
The remaining ~4 seconds (compared to ~2 seconds in 2.18) are due
to the check for enums and provider-side constraints, that were
not implemented in 2.18.
See: QgsEnumerationWidgetFactory::fieldScore and the call to
enumValues for details, fieldScore is called several times
because QgsAttributeTableModel::loadAttributes is also
called multiple times and it queries for widget configuration
all the times.