Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expression] Negative index support to point_n(), angle_at_vertex(), distance_to_vertex() functions #9490

Merged
merged 1 commit into from Mar 13, 2019

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Mar 12, 2019

Description

Because we all love negative index support.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@nyalldawson
Copy link
Collaborator

Can you update the help accordingly?

@nirvn
Copy link
Contributor Author

nirvn commented Mar 12, 2019

@nyalldawson , that's not a bad idea! 😉

@DelazJ
Copy link
Contributor

DelazJ commented Mar 12, 2019

@nirvn nirvn changed the title [expression] Add negative index support to point_n() function [expression] Negative index support to point_n(), angle_at_vertex(), distance_to_vertex() functions Mar 13, 2019
@nirvn
Copy link
Contributor Author

nirvn commented Mar 13, 2019

@nyalldawson , function help ammended.

@DelazJ , negative index support added to angle_at_vertex() and distance_to_vertex() functions. We can't harmonize the index (1 vs 0 as starting point) until QGIS 4.0, let's keep that in mind when we cross that bridge.

@nirvn nirvn merged commit b97ef93 into qgis:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants