Fix regression server print selection pdf release 3.4 #9692

rldhont · 2019-04-02T11:55:00Z

Description

Manually backporting fix inconsistent use of layout render context flags 2752f83 to fix draw selection in Server GetPrint Request.
And backporting unit-tests to avoid regression in QGIS Server context.

Checklist

Commit messages are descriptive and explain the rationale for changes
I have read the QGIS Coding Standards and this PR complies with them
This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
New unit tests have been added for core changes
I have run the scripts/prepare-commit.sh script before each commit

rldhont · 2019-04-04T11:10:58Z

Hi @elpaso , @pblottiere now that #9654 has been merged and waiting for backport #9705 can you review this one ? thanks

nyalldawson · 2019-04-04T23:42:54Z

src/core/layout/qgslayoutexporter.cpp

@@ -490,6 +490,8 @@ QgsLayoutExporter::ExportResult QgsLayoutExporter::exportToPdf( const QString &f
  ( void )contextRestorer;
  mLayout->renderContext().setDpi( settings.dpi );

+  mLayout->renderContext().setFlags( settings.flags );


I'm not 100% sure, but this change may only have been ok in 3.6/master because of corresponding changes in the layout designer dialog. Can you look through the git blame on master for when I introduced this and please confirm that there's no related changes made in the designer to accompany this?

@nyalldawson you're right an other commit is associated in the PR [needs-docs][layouts] Add checkbox to disable raster tiling for PDF/SVG exports #9016.

Do you think the other commit has to be backported ?
Does the Fix inconsistent use of layout render context flags 2752f83 introduced some regressions ?

The issue fixed by your PR is https://issues.qgis.org/issues/19500 Layout export - raster divided into tiles, edges evident in pdf/svg

@nyalldawson can I cherry-pick 60b8d05#diff-b7c7a3b8898bc4177771ab86148a8348 ?

This change is not linked to layout designer dialog. I have introduced flag in layout to print selection in server context.
I have done the code for release 3.4.0 with the PR #8320 [Server] Reactivate the capability to print selection with Server 3.4

Hi @nyalldawson,

The mLayout->renderContext().setFlags( settings.flags ); has been introduced before the Refactor layout context 5bc543a
https://github.com/qgis/QGIS/blame/master/src/core/layout/qgslayoutexporter.cpp#L356 in QGIS 3.0.0 in method exportToImage because this commit only rename the context access in layout.

The mLayout->context().setFlags( settings.flags ); has been introduced before the **Work on PDF export ** 91179f1 in QGIS 3.0.0 in which you introduce exportToPdf and the setFlags missed.

In this commit you wrote

// If we are not printing as raster, temporarily disable advanced effects // as QPrinter does not support composition modes and can result // in items missing from the output mLayout->context().setFlag( QgsLayoutContext::FlagUseAdvancedEffects, settings.rasteriseWholeImage );

But flags are not set before.

The mLayout->context().setFlags( settings.flags ); in exportToImage has been introduced by Expose antialiasing option in image export dialog 2f0969e#diff-7393cc3d739cdcd8a6531909637b63b5

rldhont · 2019-04-16T10:49:38Z

Hi @nyalldawson, I would like to know what can I do to fix tise server regression ?
Do I cherry-pick your fix 60b8d05 ?

Thanks for your review.

rldhont · 2019-04-18T06:56:01Z

Hi @nyalldawson I have cherry-pick 60b8d05 so this PR is also a backport of PR [needs-docs][layouts] Add checkbox to disable raster tiling for PDF/SVG exports #9016.

nyalldawson · 2019-04-18T07:16:57Z

Thanks @rldhont. I don't have time to review this until late next week, so PLEASE thoroughly test that theres no regressions in the designer GUI. It makes me quite nervous backporting this to the stable LTR branch.

rldhont · 2019-04-18T07:30:29Z

@nyalldawson thanks for your reply, I'll test the UI. Do you think someone else can review this ?

rldhont · 2019-04-18T10:49:32Z

@nyalldawson tested without issue

rldhont · 2019-04-19T09:48:36Z

Can I merge ?

rldhont · 2019-04-23T07:31:54Z

@nyalldawson Now that QGIS 3.4.7 has been released, do you think, I can merge this ? Other devs can test it ?

stale · 2019-05-10T03:40:01Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

rldhont · 2019-05-10T08:06:11Z

Hi @nyalldawson, can I have a decision about this bugfix ?

rldhont · 2019-05-14T08:02:14Z

Hi @nyalldawson, Do you think it is acceptable to only backport the commit 0954deaf97638519e9f4b3e28855e03a8a34f5c1 Fix inconsistent use of layout render context flags
and remove the commit 30d147aadc3a590916a04190bfa525e736521ad7 [needs-docs][layouts] Add checkbox to disable raster tiling for PDF/SVG exports that updates the UI ?

…ormat In QGIS 3.4, Selection can be printed in Image output and not in PDF or SVG output. A fix has been done 2752f83 to fix inconsistent use of layout render context flags, and draw selection is activated with a flag.

rldhont · 2019-06-01T13:52:22Z

Hi @nyalldawson,

The setFlags method in layout exporter has been introduced to apply anti-aliasing option.
It seems that no other flags are available and no flags can be configurable for other layout export.

pblottiere · 2019-06-11T14:06:49Z

Hi @rldhont,

Considering the fact that the impact on the code is pretty minimal, I'd be in favor of merging this PR. Moreover, unit tests have been added too.

Initially, some worries had been expressed about border effects on the designer GUI, but I think that you have tested it, isn't it? If so, I propose to merge this PR in the coming days, unless an objection is raised in the meantime.

rldhont · 2019-06-11T18:08:29Z

Hi @pblottiere,

I have tested the GUI and I didn't see any border effects.

Thanks,

rldhont · 2019-06-14T15:17:14Z

Thanks @pblottiere

rldhont added Bugfix labels Apr 2, 2019

rldhont added this to the 3.4.7 milestone Apr 2, 2019

rldhont requested review from elpaso, nyalldawson and pblottiere April 2, 2019 11:55

rldhont mentioned this pull request Apr 2, 2019

add selection in GetPrint request 3liz/lizmap-web-client#1153

Closed

nyalldawson reviewed Apr 4, 2019

View reviewed changes

rldhont added the Backport Is a backport of another pull request label Apr 18, 2019

rldhont force-pushed the fix-regression-server-print-selection-pdf-release-3_4 branch from c54d86e to 30d147a Compare April 18, 2019 08:35

nyalldawson modified the milestones: 3.4.7, 3.4.8 Apr 26, 2019

stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label May 10, 2019

stale bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label May 10, 2019

nyalldawson modified the milestones: 3.4.8, 3.4.9 May 19, 2019

nyalldawson and others added 2 commits May 20, 2019 17:02

Fix inconsistent use of layout render context flags

8e57dad

rldhont force-pushed the fix-regression-server-print-selection-pdf-release-3_4 branch from 30d147a to ea5bcdc Compare May 20, 2019 15:02

nyalldawson added Bug Either a bug report, or a bug fix. Let's hope for the latter! and removed Unit Testing labels May 26, 2019

pblottiere approved these changes Jun 14, 2019

View reviewed changes

rldhont merged commit 3ed9a53 into qgis:release-3_4 Jun 14, 2019

rldhont deleted the fix-regression-server-print-selection-pdf-release-3_4 branch June 14, 2019 16:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix regression server print selection pdf release 3.4 #9692

Fix regression server print selection pdf release 3.4 #9692

rldhont commented Apr 2, 2019 •

edited

rldhont commented Apr 4, 2019

nyalldawson Apr 4, 2019

rldhont Apr 5, 2019

rldhont Apr 5, 2019

rldhont Apr 11, 2019

rldhont May 20, 2019

rldhont May 24, 2019

rldhont commented Apr 16, 2019

rldhont commented Apr 18, 2019

nyalldawson commented Apr 18, 2019

rldhont commented Apr 18, 2019

rldhont commented Apr 18, 2019

rldhont commented Apr 19, 2019

rldhont commented Apr 23, 2019

stale bot commented May 10, 2019

rldhont commented May 10, 2019

rldhont commented May 14, 2019

rldhont commented Jun 1, 2019

pblottiere commented Jun 11, 2019

rldhont commented Jun 11, 2019

rldhont commented Jun 14, 2019

Fix regression server print selection pdf release 3.4 #9692

Fix regression server print selection pdf release 3.4 #9692

Conversation

rldhont commented Apr 2, 2019 • edited

Description

Checklist

rldhont commented Apr 4, 2019

nyalldawson Apr 4, 2019

Choose a reason for hiding this comment

rldhont Apr 5, 2019

Choose a reason for hiding this comment

rldhont Apr 5, 2019

Choose a reason for hiding this comment

rldhont Apr 11, 2019

Choose a reason for hiding this comment

rldhont May 20, 2019

Choose a reason for hiding this comment

rldhont May 24, 2019

Choose a reason for hiding this comment

rldhont commented Apr 16, 2019

rldhont commented Apr 18, 2019

nyalldawson commented Apr 18, 2019

rldhont commented Apr 18, 2019

rldhont commented Apr 18, 2019

rldhont commented Apr 19, 2019

rldhont commented Apr 23, 2019

stale bot commented May 10, 2019

rldhont commented May 10, 2019

rldhont commented May 14, 2019

rldhont commented Jun 1, 2019

pblottiere commented Jun 11, 2019

rldhont commented Jun 11, 2019

rldhont commented Jun 14, 2019

rldhont commented Apr 2, 2019 •

edited