[3d] Fix unnecessary terrain map updates when changing 3D renderer #9839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using layer styling dock, every change in 3D rendering configuration was also triggering update of 2D map which also forces update of all terrain tile textures with a new 2D map which wasn't really needed. The fix makes the triggerRefresh() call on layer optional - each layer styling dock config widget can tell whether its updates require 2D map refresh (true by default).
nyalldawson
approved these changes
Apr 22, 2019
| * (for example 3D rendering config) do not need layer repaint as they do not modify 2D map rendering. | ||
| * \since QGIS 3.8 | ||
| */ | ||
| virtual bool shouldTriggerLayerRepaint() const { return true; } |
There was a problem hiding this comment.
Would a flags based approach be more appropriate here? I'm 50/50
There was a problem hiding this comment.
Generally my feeling is that flags are better when a class is made to be used as is and flags can modify its behavior based on caller's preference. When a class is made to be derived and the behavior is defined by the implementation of derived class, a virtual method feels better. But no strong opinion...
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using layer styling dock, every change in 3D rendering configuration
was also triggering update of 2D map which also forces update of all
terrain tile textures with a new 2D map which wasn't really needed.
The fix makes the triggerRefresh() call on layer optional - each layer
styling dock config widget can tell whether its updates require 2D map
refresh (true by default).